Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: transmit http body as bytes instead of string #3254

Merged
merged 2 commits into from Oct 13, 2023
Merged

fix: transmit http body as bytes instead of string #3254

merged 2 commits into from Oct 13, 2023

Conversation

mathnogueira
Copy link
Member

This PR makes the agent use []byte in the HTTP response body. This prevents UTF-8 encoding errors.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

@mathnogueira mathnogueira merged commit e4debd9 into main Oct 13, 2023
38 checks passed
@mathnogueira mathnogueira deleted the fix/utf8-error-agent branch October 13, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mathnogueira @xoscar