Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): Datastore test pipeline #3261

Merged
merged 1 commit into from Oct 13, 2023
Merged

fix(server): Datastore test pipeline #3261

merged 1 commit into from Oct 13, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Oct 13, 2023

This PR fixes a problem with the missing meter from the data store pipeline used for the queues

Changes

  • Adds meter instance to the data store connection test pipeline

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/e1a384635b8b43019ded00ab47e6861d

@xoscar xoscar self-assigned this Oct 13, 2023
@xoscar xoscar marked this pull request as ready for review October 13, 2023 21:03
@xoscar xoscar merged commit a91e7a8 into main Oct 13, 2023
35 of 38 checks passed
@xoscar xoscar deleted the fix/datastore-test-pipeline branch October 13, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathnogueira mathnogueira mathnogueira approved these changes

@schoren schoren Awaiting requested review from schoren

@jorgeepc jorgeepc Awaiting requested review from jorgeepc

@danielbdias danielbdias Awaiting requested review from danielbdias

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xoscar @mathnogueira