Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use signle gomod #3289

Merged
merged 7 commits into from Oct 25, 2023
Merged

use signle gomod #3289

merged 7 commits into from Oct 25, 2023

Conversation

schoren
Copy link
Collaborator

@schoren schoren commented Oct 20, 2023

This PR removes the go.work file and centralizes all go deps in a single go.mod at the project root. This means that the root package is now github.com/kubeshop/tracetest. Key benefits:

  1. Automatic dep version sync betweeen CLI, server, agent and any future project
  2. no need to import different parts throug go mod (for example importing server on CLI)
  3. no more go.work diff because of IDEs

All the builds are still working, so this is a very "internal" change that shouldn't affect anything other than go's dep management

@schoren schoren marked this pull request as ready for review October 23, 2023 14:30
@schoren schoren merged commit ee479bf into main Oct 25, 2023
37 checks passed
@schoren schoren deleted the centralize-gomod branch October 25, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants