Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): Adding Composed Primary Keys #3345

Merged
merged 2 commits into from Nov 10, 2023
Merged

fix(backend): Adding Composed Primary Keys #3345

merged 2 commits into from Nov 10, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Nov 10, 2023

This PR fixes the problem when trying to use the same ID for tests, test suites, and variable sets from a different tenant ID perspective

Changes

  • Adds migrations to use composed primary keys for the missing tables
  • Fixes queries around listing and getting tests/test suites by adding tenant id

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/bd1cbd2dc57e46cfb50c710a8ac00119

@xoscar xoscar self-assigned this Nov 10, 2023
@xoscar xoscar marked this pull request as ready for review November 10, 2023 17:54
@xoscar xoscar merged commit 5d509a1 into main Nov 10, 2023
38 checks passed
@xoscar xoscar deleted the fix/composed-primary-keys branch November 10, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schoren schoren schoren approved these changes

@danielbdias danielbdias danielbdias approved these changes

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xoscar @schoren @danielbdias