Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: host network configuration on linux #3394

Merged
merged 1 commit into from Nov 23, 2023
Merged

fix: host network configuration on linux #3394

merged 1 commit into from Nov 23, 2023

Conversation

mathnogueira
Copy link
Member

@mathnogueira mathnogueira commented Nov 23, 2023 •
edited

Docker on Linux doesn't understand host.docker.internal automatically. We need to add it as an extra host using extra_hosts. This was caught by @mrasu in the issue #3393.

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

@mathnogueira
fix: host network configuration on linux
d14595a 
Docker on Linux doesn't understand `host.docker.internal` automatically.
We need to add it as an extra host using `extra_hosts`. This was caught
by @mrasu in his issue #3393.
@mathnogueira mathnogueira merged commit 25ad0bd into main Nov 23, 2023
38 checks passed
@mathnogueira mathnogueira deleted the fix/agent-pokeshop-example branch November 23, 2023 15:37
@mathnogueira mathnogueira mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@xoscar xoscar xoscar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mathnogueira @jorgeepc @xoscar