Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): remove variable set description validation #3404

Merged
merged 1 commit into from Nov 27, 2023

Conversation

jorgeepc
Copy link
Contributor

This PR fixes a bug with the description field of a VariableSet. It's not required anymore but it was still part of the validation service.

Changes

  • remove description as required for VariableSet

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc self-assigned this Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (83bb2f1) 39.43% compared to head (97f8282) 39.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3404   +/-   ##
=======================================
  Coverage   39.43%   39.43%           
=======================================
  Files         222      222           
  Lines       16973    16973           
=======================================
  Hits         6694     6694           
  Misses       9693     9693           
  Partials      586      586           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jorgeepc jorgeepc requested a review from xoscar November 27, 2023 21:24
@jorgeepc jorgeepc merged commit 7bbafb4 into main Nov 27, 2023
40 checks passed
@jorgeepc jorgeepc deleted the fix-variable-set-description-validation branch November 27, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants