Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): minor UI issues #3411

Merged
merged 1 commit into from Nov 29, 2023
Merged

fix(frontend): minor UI issues #3411

merged 1 commit into from Nov 29, 2023

Conversation

jorgeepc
Copy link
Contributor

This PR fixes a couple of minor UI issues:

  • skip trace collection setting was not updated in the trigger section
  • test suite UI was breaking the layout for larger test suites names
  • link to trigger settings tab was not using the proper Link component

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/a084800f1deb434390f04e64f646b0ba?sid=18ad0992-13d0-418a-b18f-1336f990ed50

@jorgeepc jorgeepc self-assigned this Nov 29, 2023
xoscar
xoscar approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great findings! 🚀

@jorgeepc jorgeepc merged commit bd99e40 into main Nov 29, 2023
38 checks passed
@jorgeepc jorgeepc deleted the fix-minor-ui-bugs branch November 29, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestSuite UI breaks layout for larger TestSuite names
2 participants
@jorgeepc @xoscar