Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: add new opentelemetry filter to filter tracetest traces #3422

Merged
merged 5 commits into from Dec 4, 2023
Merged

example: add new opentelemetry filter to filter tracetest traces #3422

merged 5 commits into from Dec 4, 2023

Conversation

mathnogueira
Copy link
Member

@mathnogueira mathnogueira commented Dec 4, 2023 •
edited

This PR adds the new filter capability to sample only traces generated by tracetest and send them to Tracetest.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@mathnogueira mathnogueira added documentation Improvements or additions to documentation examples labels Dec 4, 2023
@mathnogueira @jfermi
Apply suggestions from code review
e55d2ff 
Co-authored-by: Julianne Fermi <julianne@kubeshop.io>
jfermi
jfermi reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@jfermi jfermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editing suggestions.

@mathnogueira mathnogueira merged commit 8ea7a6c into main Dec 4, 2023
38 checks passed
@mathnogueira mathnogueira deleted the example/collector-filtering branch December 4, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfermi jfermi jfermi left review comments

@danielbdias danielbdias danielbdias approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mathnogueira @danielbdias @jfermi