Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): Return type for browser spans #3443

Merged
merged 4 commits into from Dec 15, 2023
Merged

fix(server): Return type for browser spans #3443

merged 4 commits into from Dec 15, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Dec 14, 2023

This PR updates the check for browser spans to return general while we decide what to do next.

Changes

  • Adds a check for browser spans and returns general type

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar marked this pull request as ready for review December 14, 2023 22:25
@xoscar xoscar merged commit c9f1526 into main Dec 15, 2023
38 checks passed
@xoscar xoscar deleted the fix-browser-spans branch December 15, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathnogueira mathnogueira mathnogueira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xoscar @mathnogueira