fix: skip open attribute list step on e2e #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoren
approved these changes
Dec 27, 2023
danielbdias
commented
Dec 27, 2023
| @@ -146,80 +146,45 @@ jobs: | |||
| with: | |||
| fetch-depth: 0 | |||
|
|
|||
| - name: set cache keys | |||
There was a problem hiding this comment.
Our cache is causing false positives and negatives during our tests, causing our tests not to capture changes that should break tests.
This allowed us to merge a PR with a false negative test (the PR that changed the behavior of the Trace tab) and blocked this PR with a false positive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes our Cypress e2e tests that are breaking due to a behavior change on our UI. Since we already open the Attribute list on the Trace and Test tabs, there is no need of having of clicking on the expand button to show the list.
Fixes
Checklist