Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): add nats subscription manager #3522

Merged
merged 12 commits into from Jan 15, 2024
Merged

feat(server): add nats subscription manager #3522

merged 12 commits into from Jan 15, 2024

Conversation

schoren
Copy link
Collaborator

@schoren schoren commented Jan 11, 2024

This PR adds a NATS subscription manager

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

mathnogueira
mathnogueira approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@mathnogueira mathnogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few cleanup comments

server/executor/test_suite_runner_test.go Outdated Show resolved Hide resolved
server/subscription/message.go Outdated Show resolved Hide resolved
schoren and others added 2 commits January 15, 2024 17:18
@schoren @mathnogueira
Update server/executor/test_suite_runner_test.go
87c3de6 
Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com>
@schoren @mathnogueira
Update server/subscription/message.go
339874c 
Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com>
@schoren schoren merged commit 29ae31c into main Jan 15, 2024
37 checks passed
@schoren schoren deleted the fix-subscription-manager branch January 15, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathnogueira mathnogueira mathnogueira approved these changes

@danielbdias danielbdias danielbdias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schoren @mathnogueira @danielbdias