New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: port parsing when using HTTP/HTTPS with omitted port #3524

Merged

mathnogueira merged 4 commits into main from fix/port-parsing

Jan 12, 2024

Member

mathnogueira commented Jan 12, 2024

This PR fixes our function to parse ports from URL and also make sure to get the omitted port when the URL is either HTTP or HTTPS.

Checklist

tested locally
added new dependencies
updated the docs
added a test

mathnogueira added 4 commits

January 12, 2024 16:56


          fix: port parsing when using HTTP/HTTPS with omitted port

5dac3b8


          clean up

758d11c


          use real urls in test

faed6f3


          add examples of overriding the default ports for http and https

ab8a2a9

xoscar approved these changes

View reviewed changes

mathnogueira merged commit 3f91673 into main

37 checks passed

mathnogueira deleted the fix/port-parsing branch

January 12, 2024 20:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment