feat: otlp connection span count/reset endpoints #3533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
approved these changes
Jan 16, 2024
| i.mutex.Lock() | ||
| defer i.mutex.Unlock() | ||
|
|
||
| i.spanCount += newSpansCount |
There was a problem hiding this comment.
Sanity check question: Does this counter consider different counts for tenantIds?
There was a problem hiding this comment.
No, it doesn't. However, this ingester is only used by the core version, thus tenant ids are irrelevant. The agent ingester must care about it though.
server/testconnection/otlp.go
Outdated
|
|
||
| func (t *OTLPConnectionTester) GetSpanCount(ctx context.Context, opts ...GetSpanCountOption) (OTLPConnectionTestResponse, error) { | ||
| config := getSpanCountConfig{ | ||
| timeout: 30 * time.Second, |
There was a problem hiding this comment.
Can we move this timeout to a constant?
schoren
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the implementation for counting the number of spans received by the OTLP ingester.
Checklist