Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make test connection async on trace polling step #3534

Merged
merged 2 commits into from Jan 18, 2024
Merged

fix: make test connection async on trace polling step #3534

merged 2 commits into from Jan 18, 2024

Conversation

danielbdias
Copy link
Contributor

This PR changes the Test Connection action on the Trace Polling start to be async.

Fixes

  • Update Test Connection action on the Trace Polling start to be async.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

mathnogueira
mathnogueira approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@mathnogueira mathnogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment

@danielbdias @mathnogueira
Update server/executor/tracepollerworker/starter_worker.go
abaec41 
Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com>
@danielbdias danielbdias merged commit 121ec57 into main Jan 18, 2024
37 checks passed
@danielbdias danielbdias deleted the fix/trace-polling-test-connection branch January 18, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathnogueira mathnogueira mathnogueira approved these changes

@schoren schoren Awaiting requested review from schoren

@xoscar xoscar Awaiting requested review from xoscar

@jorgeepc jorgeepc Awaiting requested review from jorgeepc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielbdias @mathnogueira