feat: agent collector statistics report #3544
Conversation
mathnogueira
changed the title
| continue | ||
| } | ||
|
|
||
| // TODO: Get ctx from request |
There was a problem hiding this comment.
Philosophical question: is there a way to get the context from the request?
My impression is that there is no way to get these contexts due to the passive nature of getting the messages.
Could we create a context in the future and change it by monitoring the stream connection?
There was a problem hiding this comment.
We would need to propagate headers through the messages to be able to create a context from the request (propagate the otel headers)
| @@ -7,14 +7,14 @@ import ( | |||
| "github.com/kubeshop/tracetest/agent/proto" | |||
| ) | |||
|
|
|||
| func (c *Client) SendDataStoreConnectionResult(ctx context.Context, response *proto.DataStoreConnectionTestResponse) error { | |||
| func (c *Client) SendOTLPConnectionResult(ctx context.Context, response *proto.OTLPConnectionTestResponse) error { | |||
There was a problem hiding this comment.
Is the renaming of this function correct? seems that there is a new file about oltp
There was a problem hiding this comment.
Not correct, nice catch. Unfortunately this endpoint isn't covered by a test, that's why I didn't get this error :(
There was a problem hiding this comment.
fixed the mess and also added tests to ensure it will not break in the future
This PR makes the agent report some statistics to the server when requested.
Checklist