Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): indicate tabs with info in trigger #3565

Merged
merged 2 commits into from Jan 26, 2024
Merged

Conversation

jorgeepc
Copy link
Contributor

This PR adds the components to indicate which tabs have information on them on the trigger page. It also fixes a small navigation issue in our test suite detail page.

Changes

  • TriggerTab component and logic to detect tabs with information
  • fix navigation issue

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshot

2024-01-25 13 31 58

@jorgeepc jorgeepc self-assigned this Jan 25, 2024
@jorgeepc jorgeepc requested a review from xoscar January 25, 2024 18:36
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgeepc changes look good, I was thinking about the color for the tabs tho, green looks a little bit off, but we can update that later if needed

@jorgeepc
Copy link
Contributor Author

@jorgeepc changes look good, I was thinking about the color for the tabs tho, green looks a little bit off, but we can update that later if needed

@xoscar Olga suggested a light gray but it does not look good IMO. Let me try with a different color

@jorgeepc jorgeepc merged commit 075bf47 into main Jan 26, 2024
37 checks passed
@jorgeepc jorgeepc deleted the feat-trigger-tabs branch January 26, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants