Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding observability stack example #3578

Merged
merged 7 commits into from Jan 30, 2024

Conversation

danielbdias
Copy link
Contributor

This PR adds an example that shows the user how to create an observability stack, plug an API into it, and do some trace based tests.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Copy link
Member

@jfermi jfermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing suggestions.

Copy link
Contributor

@adnanrahic adnanrahic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny suggestions.

examples/observability-stack/README.md Outdated Show resolved Hide resolved
examples/observability-stack/README.md Outdated Show resolved Hide resolved
examples/observability-stack/README.md Outdated Show resolved Hide resolved
examples/observability-stack/README.md Outdated Show resolved Hide resolved
examples/observability-stack/README.md Outdated Show resolved Hide resolved
Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 9:45pm

Comment on lines +4 to +11
tracetest:
image: kubeshop/tracetest-agent:latest
platform: linux/amd64
depends_on:
otel-collector:
condition: service_started
environment:
TRACETEST_API_KEY: ${TRACETEST_API_KEY}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We the agent will access http://host.docker.internal:8080/, it's better to add the extra_hosts parameter to make sure Linux users will be able to run this example:

extra_hosts:
      - "host.docker.internal:host-gateway"

@danielbdias danielbdias merged commit 28999b9 into main Jan 30, 2024
39 checks passed
@danielbdias danielbdias deleted the add/observability-stack-example branch January 30, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants