Changes to Typescript Quickstart #3582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A large number of our quick starts reference the docs in the readme rather than duplicating the steps to run - I changed the Readme to follow this convention and pointed users to it. Placed the steps to run the quick start in the docs. Removed material explaining how the tracetest agent connection, collector configuration, and docker compose network are configured so the quick start focuses solely on the use of the NPM package.
jfermi
reviewed
Jan 30, 2024
jfermi
reviewed
Jan 30, 2024
Co-authored-by: Julianne Fermi <julianne@kubeshop.io>
Co-authored-by: Julianne Fermi <julianne@kubeshop.io>
jfermi
approved these changes
Jan 30, 2024
adnanrahic
reviewed
Jan 30, 2024
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
Co-authored-by: Adnan Rahić <adnan@kubeshop.io>
xoscar
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made several changes:
A large number of our quick starts reference the docs in the readme rather than duplicating the steps to run - I changed the Readme to follow this convention and pointed users to it.
Moved the steps to run the quick start from the Readme into the docs.
Removed material explaining how the tracetest agent connection, collector configuration, and docker compose network are configured so the quick start focuses solely on the use of the NPM package. As I read the quick start initially all the other information distracted me from the goal of showing how to use the NPM library.