Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): correctly handle trailing slash in server url #3586

Merged
merged 1 commit into from Jan 31, 2024

Conversation

schoren
Copy link
Collaborator

@schoren schoren commented Jan 31, 2024

This PR fixes the handling of user given urls either having trailing slash or not.

Before

Screenshot 2024-01-31 at 15 07 04

After

Screenshot 2024-01-31 at 15 08 06

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview Jan 31, 2024 6:08pm

@schoren schoren merged commit 69393fc into main Jan 31, 2024
39 checks passed
@schoren schoren deleted the handle-config-trailing-slash branch January 31, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants