feat(server): add endpoint to search spans in a trace #3611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an endpoint that allows searching spans within a trace.
The query is transmitted via post body to avoid possible issues with URL length if the query is a bit large.
The plain text implementation is a bit naive, it just does a
string.contains
over a json encoded version of each span, both the query and the json lowercased for improved matching.While this is a pretty terrible implementation, it's easy and it works. In the future if needed we could implement a more complex solution, like Bleve, ElasticSearch, etc, but at this time this seems like a good enough approach.
Examples:
Search by query language
Search by text
Loom video
https://www.loom.com/share/e2912a4fde554a85a8dfb043fca983fc