Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): Adding Cypress and Playwright examples #3618

Merged
merged 2 commits into from Feb 9, 2024
Merged

chore(examples): Adding Cypress and Playwright examples #3618

merged 2 commits into from Feb 9, 2024

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Feb 8, 2024

This PR adds examples for both Cypress and Playwright, so we have them as part of the main repo not only on the pokeshop repo.

Changes

  • Adds Cypress example
  • Adds Playwright example

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar self-assigned this Feb 8, 2024
@xoscar xoscar marked this pull request as ready for review February 8, 2024 22:02
@vercel Vercel
Copy link

vercel bot commented Feb 8, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 6:20pm

jorgeepc
jorgeepc approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@jorgeepc jorgeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

adnanrahic
adnanrahic reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@adnanrahic adnanrahic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!!!

I see in the readme you say it's using OpenTelemetry Collector but there is a Jaeger URL in the collector.config.yaml. Is this what you want or did you forget removing something?

@xoscar xoscar merged commit 00a4d3c into main Feb 9, 2024
39 checks passed
@xoscar xoscar deleted the chore-e2e-examples branch February 9, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnanrahic adnanrahic adnanrahic left review comments

@jorgeepc jorgeepc jorgeepc approved these changes

@kdhamric kdhamric Awaiting requested review from kdhamric

@jfermi jfermi Awaiting requested review from jfermi

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xoscar @jorgeepc @adnanrahic