feat: propagete trace context in queues #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mathnogueira
commented
Feb 15, 2024
Comment on lines
+83
to
+87
| workerCtx := context.Background() | ||
| if propagator := otel.GetTextMapPropagator(); propagator != nil { | ||
| var carrier propagation.HeaderCarrier | ||
| workerCtx = propagator.Extract(workerCtx, carrier) | ||
| } |
There was a problem hiding this comment.
I need a new context here because ctx will be canceled right after this function returns. If I use it, all tests hang.
schoren
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the context be propagated to all queues
Checklist
Loom video
Add your loom video here if your work can be visualized