feat(cli): add open telemetry support for Tracetest agent #3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danielbdias
commented
Feb 19, 2024
cli/config/configurator.go
Outdated
| @@ -162,6 +162,19 @@ func (e invalidServerErr) Render() { | |||
| } | |||
|
|
|||
| func (c Configurator) populateConfigWithVersionInfo(ctx context.Context, cfg Config) (_ Config, _ error, isOSS bool) { | |||
| cliVersion := Version | |||
| if cliVersion == "dev" { | |||
There was a problem hiding this comment.
Helper code to help us to run the agent locally when the cliVersion is dev
There was a problem hiding this comment.
Can we point the agent to a different environment from a dev build too? I want to make sure this will allows us to be flexible enough when debugging
There was a problem hiding this comment.
Yes! Added an update to allow these config to be configured by env vars.
danielbdias
requested review from
schoren,
mathnogueira,
jorgeepc and
xoscar
schoren
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for OTel Collector on Tracetest Agent.
Changes
Checklist