Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add vertical resizer in timeline view #3670

Merged
merged 5 commits into from Feb 23, 2024

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Feb 20, 2024

This PR introduces a column resizer for the span name column in the Timeline view.

Changes

  • new DraggableManager utility
  • resizable span name in Timeline view

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/1517691350174565ab0b4dc557a484c9?sid=0fdc36aa-e2a4-4684-8acc-475d6cbfb057

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 8:03pm

const [dragPosition, setDragPosition] = useState<number | null>(null);

useEffect(() => {
const draggableManager = DraggableManager({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this adds a lot of notice for the component, should we move this to a hook?

@jorgeepc jorgeepc merged commit 78a2ecd into main Feb 23, 2024
39 checks passed
@jorgeepc jorgeepc deleted the feat-add-vertical-resizer branch February 23, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add draggable column in Timeline view
2 participants