feat: support contains to compare json objects
#3687
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| if rightValue.Value().Type == types.TypeJson && comparatorName == "contains" { | ||
| if leftValue.Value().Type == types.TypeJson || leftValue.Value().Type == types.TypeArray { | ||
| comparatorName = "json-contains" | ||
| } | ||
| } |
There was a problem hiding this comment.
I thought this was cleaner to write than a longer if statement containing all four conditions.
| { | ||
| Name: "should_be_able_to_compare_with_subset", | ||
| Query: `'{"name": "john", "age": 32, "email": "john@company.com"}' contains '{"email": "john@company.com", "name": "john"}'`, | ||
| ShouldPass: true, | ||
| }, |
There was a problem hiding this comment.
I would add another case here as a sanity check: comparing the same object, but with different attribute orders, like:
{"name": "john", "age": 32, "email": "john@company.com"}' contains '{"email": "john@company.com", "name": "john", "age": "32"}
| { | ||
| Name: "should_match_complete_arrays", | ||
| Query: `'{"numbers": [0,1,2,3,4]}' contains '{"numbers": [0,1,2,3,4]}'`, | ||
| ShouldPass: true, | ||
| }, |
There was a problem hiding this comment.
Based on this case, I would add a case to test arrays that seems to be equal, but doesn't, like:
{"numbers": [0,1,2,3,4]}' contains '{"numbers": [0,1,"2","3",4]}
| executeTestCases(t, testCases) | ||
| } | ||
|
|
||
| func TestJSONExecution(t *testing.T) { |
There was a problem hiding this comment.
Does it make sense to add a comparison for escaped JSON? Something like:
'{"name": "john", "age": 32, "email": "john@company.com"}' contains '{\"email\": \"john@company.com\" }'
There was a problem hiding this comment.
Escaping is not stable in the engine. As this is a problem in the core of the engine and not in the feature, I'll skip this and wait for users to ask for a fix. Not sure if that will happen.
| Name: "should_be_able_to_compare_deep_objects_in_subset", | ||
| Query: `'{"name": "john", "age": 32, "email": "john@company.com", "company": {"name": "Company", "address": "1234 Agora Street"}}' contains '{"email": "john@company.com", "name": "john", "company": {"name": "Company"}}'`, | ||
| ShouldPass: true, |
There was a problem hiding this comment.
Maybe a test with deep objects and arrays?
{"name": "john", "age": 32, "email": "john@company.com", "company": {"name": "Company", "address": "1234 Agora Street", "telephones": ["01", "02", "03"]}}' contains '{"email": "john@company.com", "name": "john", "company": {"name": "Company", "telephones": ["01", "02", "03"]}}
Co-authored-by: Julianne Fermi <julianne@kubeshop.io>
This PR allows an expression to compare two json objects with a
subsetrelationship. Related to #3684Checklist
Loom video
Check tests for details