Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new devops agent for jdk11 #39

Merged
merged 8 commits into from
Dec 20, 2021
Merged

add new devops agent for jdk11 #39

merged 8 commits into from
Dec 20, 2021

Conversation

mangoGoForward
Copy link
Contributor

@mangoGoForward mangoGoForward commented Nov 3, 2021 •
edited
Loading

What this PR dose?

Add new pod template for Maven with JDK 11

What this PR does / why we need it:

please see #28.

Which issue(s) this PR fixes:

Fixes #28 .

How to test?

  1. Install ks-devops via helm charts
make install-chart
  1. Create a test Pipeline
    Pipeline script example:
pipeline {
  agent {
    node {
      label 'jdk11'
    }
  }
  stages {
    stage('Greet') {
      steps {
        container('maven') {
          sh '''mvn -version'''
        }
      }
    }
  }
}

@ks-ci-bot
Copy link
Contributor

@mangoGoForward: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

please see #28.

Which issue(s) this PR fixes:

Fixes #28 .

How to test?

  1. Install ks-devops via helm charts
make install-chart
  1. Create a test Pipeline
    Pipeline script example:
pipeline {
 agent {
   node {
     label 'maven'
   }
 }
 stages {
   stage('Greet') {
     steps {
       container('maven') {
         sh '''mvn -version'''
       }
     }
   }
 }
}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JohnNiang
JohnNiang suggested changes Nov 3, 2021
View reviewed changes
charts/ks-devops/charts/jenkins/values.yaml Outdated
@@ -430,6 +430,9 @@ Agent:
golang16:
image: builder-go
tag: v3.2.0-1.16
MavenJdk11:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a plan to refine the naming method in values.yaml for Jenkins chart, please see also #26.

So I suggest to change variable name MavenJdk11 to mavenJDK11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

LinuxSuRen
LinuxSuRen suggested changes Nov 9, 2021
View reviewed changes
charts/ks-devops/charts/jenkins/templates/jenkins-casc-config.yml Outdated
@@ -243,6 +243,72 @@ data:
securityContext:
fsGroup: 1000

- name: "mavenjdk11"
namespace: "{{ .Values.Agent.WorkerNamespace }}"
label: "maven"
Copy link
Contributor

@LinuxSuRen LinuxSuRen Nov 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two podTemplates that have the same label maven. How to use jdk11?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No opinion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mangoGoForward
refactor mavenjdk11 pod template's config, use inheritFrom to inh…
f49fcec 
…erit from `maven`

Merge remote-tracking branch 'upstream/master' into feat/jdk11
@ks-ci-bot ks-ci-bot added size/S and removed size/M labels Nov 9, 2021
LinuxSuRen
LinuxSuRen reviewed Nov 10, 2021
View reviewed changes
Copy link
Contributor

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm label Nov 10, 2021
@LinuxSuRen LinuxSuRen mentioned this pull request Nov 12, 2021
Closed
4 tasks
JohnNiang
JohnNiang approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

LinuxSuRen
LinuxSuRen reviewed Dec 20, 2021
View reviewed changes
Copy link
Contributor

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ks-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, LinuxSuRen, mangoGoForward

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot merged commit 646534d into kubesphere-sigs:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen requested changes

@AbdelouahabMbarki AbdelouahabMbarki AbdelouahabMbarki left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

Assignees

@LinuxSuRen LinuxSuRen

@JohnNiang JohnNiang

Labels
approved hacktoberfest-accepted lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request to add more pod template for newer DevOps agents
5 participants
@mangoGoForward @ks-ci-bot @LinuxSuRen @JohnNiang @AbdelouahabMbarki