-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Determine whether to log out according to the 401 and error messages on the member cluster page #1965
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harrisonliu5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7c9e834
to
686ec21
Compare
src/utils/index.js
Outdated
@@ -517,6 +517,22 @@ export const withDryRun = async requests => { | |||
export const isAppsPage = (path = location.pathname) => | |||
path === '/apps' || path.startsWith('/apps/app-') | |||
|
|||
export const isMemberClusterPage = (path = location.pathname, message) => { | |||
const member = path.indexOf('/clusters') > -1 ? path.split('/')[2] : 'host' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Precise matching is needed, similar problem: kubesphere/kubesphere#3975
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
…sages on the member cluster page Signed-off-by: harrisonliu5 <harrisonliu_5@163.com>
686ec21
to
033fbb1
Compare
/lgtm |
/cherrypick release-3.1 |
@harrisonliu5: new pull request created: #2052 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: harrisonliu5 harrisonliu_5@163.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes ##kubesphere/kubesphere/3935
Special notes for reviewers:
Additional documentation, usage docs, etc.:
/cc @wansir