Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ks cli into the base image #66

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Install ks cli into the base image #66

merged 2 commits into from
Mar 8, 2022

Conversation

LinuxSuRen
Copy link
Member

No description provided.

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2022
# ks

if [[ ${ARCH} == 'x86_64' ]]; then
curl -f https://github.com/kubesphere-sigs/ks/releases/download/v0.0.62/ks-linux-amd64.tar.gz | tar xzv && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget cURL option -LO.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

mv ks /usr/bin/
elif [[ ${ARCH} == 'aarch64' ]]
then
curl -f https://github.com/kubesphere-sigs/ks/releases/download/v0.0.62/ks-linux-arm64.tar.gz | tar xzv && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LinuxSuRen LinuxSuRen merged commit 6111c29 into master Mar 8, 2022
@LinuxSuRen LinuxSuRen deleted the ks-base branch March 8, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants