-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install ks cli into the base image #66
Conversation
base/hack/install_utils.sh
Outdated
# ks | ||
|
||
if [[ ${ARCH} == 'x86_64' ]]; then | ||
curl -f https://github.com/kubesphere-sigs/ks/releases/download/v0.0.62/ks-linux-amd64.tar.gz | tar xzv && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget cURL option -LO
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
base/hack/install_utils.sh
Outdated
mv ks /usr/bin/ | ||
elif [[ ${ARCH} == 'aarch64' ]] | ||
then | ||
curl -f https://github.com/kubesphere-sigs/ks/releases/download/v0.0.62/ks-linux-arm64.tar.gz | tar xzv && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, LinuxSuRen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.