New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a design about Pipeline Template #453
Provide a design about Pipeline Template #453
Conversation
Signed-off-by: johnniang <johnniang@fastmail.com>
Signed-off-by: johnniang <johnniang@fastmail.com>
Signed-off-by: johnniang <johnniang@fastmail.com>
Signed-off-by: johnniang <johnniang@fastmail.com>
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
==========================================
- Coverage 76.98% 76.94% -0.05%
==========================================
Files 111 113 +2
Lines 22094 22101 +7
==========================================
- Hits 17009 17005 -4
- Misses 4909 4919 +10
- Partials 176 177 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This reverts commit 58fa20e.
Hi @kubesphere/sig-devops , I found that multi-version API might be very complex. We need to create a brand new Pipeline API event if we only add template referent. Meanwhile, we also need to create a Webhook to convert CR between our versions. I'd prefer to revert Pipeline API enhancement now and fire another PR to solve those problems. What do you reckon? |
Agree! |
Signed-off-by: johnniang <johnniang@fastmail.com>
Hi @kubesphere/sig-devops , I have reverted Pipeline API improvment according to #453 (comment), please take some moment to have a look. |
Signed-off-by: johnniang <johnniang@fastmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label tide/merge-method-squash
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, LinuxSuRen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind design
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #452
Special notes for reviewers:
Hi @kubesphere/sig-devops , this PR only contains basic definition of Template API and addition of Pipeline API, not contain any reconciliation logic here. The most important thing is the design of Pipeline Template.
Does this PR introduce a user-facing change??