Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClusterTemplate API support #462

Merged
merged 4 commits into from
Feb 11, 2022

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

We have a few use cases:

  1. Official predefined Templates
  2. Some platform managers may need to create some common Templates for all departments to use.

So I create a new API: ClusterTemplate.devops.kubesphere.io, corresponding to Template.devops.kubesphere.io, for the above scenarios.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Related to #453.

Does this PR introduce a user-facing change??

None

/label tide/merge-method-squash

Signed-off-by: johnniang <johnniang@fastmail.com>
Signed-off-by: johnniang <johnniang@fastmail.com>
@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 10, 2022
Signed-off-by: johnniang <johnniang@fastmail.com>
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #462 (703e576) into master (0c15a48) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   76.93%   76.98%   +0.04%     
==========================================
  Files         118      118              
  Lines       22223    22218       -5     
==========================================
+ Hits        17098    17104       +6     
+ Misses       4946     4936      -10     
+ Partials      179      178       -1     
Flag Coverage Δ
unittests 76.98% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/devops/v1alpha1/clustertemplate_types.go 100.00% <100.00%> (ø)
controllers/template/template_controller.go
...ontrollers/jenkins/pipeline/pipeline_controller.go 43.18% <0.00%> (+3.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c15a48...703e576. Read the comment docs.

Signed-off-by: johnniang <johnniang@fastmail.com>
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2022
@ks-ci-bot ks-ci-bot merged commit e08b477 into kubesphere:master Feb 11, 2022
@JohnNiang JohnNiang deleted the feat/cluster-template-api branch February 11, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants