Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support external prometheus stack #1528

Merged

Conversation

zhu733756
Copy link
Contributor

@zhu733756 zhu733756 commented May 25, 2021

Signed-off-by: zhu733756 talonzhu@yunify.com

support external prometheus stack, fix #1503

  • split current main.yaml, move kubesphere prometheus stack outside to prometheus-stack.yaml.
  • add condition to activate the kubesphere prometheus stack.

/kind feature

/cc @benjaminhuo

Signed-off-by: zhu733756 <talonzhu@yunify.com>
@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2021
Copy link
Member

@benjaminhuo benjaminhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2021
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benjaminhuo, zhu733756
To complete the pull request process, please assign pixiake
You can assign the PR to them by writing /assign @pixiake in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benjaminhuo benjaminhuo assigned pixiake and unassigned benjaminhuo Jun 2, 2021
@benjaminhuo
Copy link
Member

@pixiake It's ok to merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to bring my own prometheus
4 participants