Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.1] combine some feature fixes by cherry-pick #1545

Merged
merged 3 commits into from
Jun 18, 2021

Conversation

zhu733756
Copy link
Contributor

@zhu733756 zhu733756 commented Jun 16, 2021

cherry-pick-to-release-3.1

The pr description updates as following:

/cc @benjaminhuo @pixiake

@ks-ci-bot ks-ci-bot added dco-signoff: yes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 16, 2021
@zhu733756 zhu733756 changed the title some feature cherry-pick-to-v3.1.0 [release-3.1] combine some feature fixes by cherry-pick Jun 16, 2021
@zryfish
Copy link
Member

zryfish commented Jun 16, 2021

Please read this doc: https://github.com/kubesphere/community/blob/master/developer-guide/development/the-pr-author-guide-to-getting-through-code-review.md. And please add the original PR link here, and more description on which features are ported to release-3.1 and why we needed in release-3.1.

Signed-off-by: zhu733756 <talonzhu@yunify.com>
Signed-off-by: zhu733756 <talonzhu@yunify.com>
Signed-off-by: zhu733756 <talonzhu@yunify.com>
@ks-ci-bot ks-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 16, 2021
@zhu733756
Copy link
Contributor Author

zhu733756 commented Jun 16, 2021

Please read this doc: https://github.com/kubesphere/community/blob/master/developer-guide/development/the-pr-author-guide-to-getting-through-code-review.md. And please add the original PR link here, and more description on which features are ported to release-3.1 and why we needed in release-3.1.

@zryfish
Copy link
Member

zryfish commented Jun 16, 2021

Please read this doc: https://github.com/kubesphere/community/blob/master/developer-guide/development/the-pr-author-guide-to-getting-through-code-review.md. And please add the original PR link here, and more description on which features are ported to release-3.1 and why we needed in release-3.1.

Thanks, please add it to the PR description, easier to find.

@zhu733756
Copy link
Contributor Author

Please read this doc: https://github.com/kubesphere/community/blob/master/developer-guide/development/the-pr-author-guide-to-getting-through-code-review.md. And please add the original PR link here, and more description on which features are ported to release-3.1 and why we needed in release-3.1.

Thanks, please add it to the PR description, easier to find.

Ok, next time i will do better!

@pixiake
Copy link
Collaborator

pixiake commented Jun 18, 2021

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, zhu733756

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2021
@pixiake
Copy link
Collaborator

pixiake commented Jun 18, 2021

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2021
@ks-ci-bot ks-ci-bot merged commit ed5a730 into kubesphere:release-3.1 Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants