Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a build flag "containers_image_openpgp" #1158

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

24sama
Copy link
Collaborator

@24sama 24sama commented Mar 29, 2022

What type of PR is this?

/kind dependencies

What this PR does / why we need it:

containers_image_openpgp: Use a Golang-only OpenPGP implementation for signature verification instead of the default cgo/gpgme-based implementation; the primary downside is that creating new signatures with the Golang-only implementation is not supported.

Add a build flag "containers_image_openpgp" to prevent dependency on gpgme.
This PR is used to support importing the github.com/containers/image/v5 package in KubeKey later.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@ks-ci-bot
Copy link
Collaborator

@24sama: The label(s) kind/dependencies cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind dependencies

What this PR does / why we need it:

containers_image_openpgp: Use a Golang-only OpenPGP implementation for signature verification instead of the default cgo/gpgme-based implementation; the primary downside is that creating new signatures with the Golang-only implementation is not supported.

Add a build flag "containers_image_openpgp" to prevent dependency on gpgme.
This PR is used to support importing the github.com/containers/image/v5 package in KubeKey later.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 29, 2022
@24sama
Copy link
Collaborator Author

24sama commented Mar 29, 2022

/dependencies

@24sama 24sama added the dependencies Pull requests that update a dependency file label Mar 29, 2022
@24sama
Copy link
Collaborator Author

24sama commented Mar 29, 2022

/cc @pixiake

@ks-ci-bot ks-ci-bot requested a review from pixiake March 29, 2022 10:50
…gpgme

Signed-off-by: 24sama <jacksama@foxmail.com>
@pixiake
Copy link
Collaborator

pixiake commented Mar 29, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 697aa6d2cd04d441a539b4ac776ba7fd5bc1119e

@ks-ci-bot ks-ci-bot merged commit d9de9a7 into kubesphere:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies Pull requests that update a dependency file lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants