-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce the size of KubeKey artifact #1160
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 24sama The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @kubesphere/sig-installation |
Signed-off-by: 24sama <jacksama@foxmail.com>
/lgtm |
LGTM label has been added. Git tree hash: 858c445f8579996c282723cd7f72216efd9f214b
|
这个提交导致无法往http的镜像源推送镜像
|
I guess you maybe used the old configure method cause this PR is a breaking changes.
|
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Reduce the size of the KubeKey artifact. This PR makes kk use github.com/containers/image to pull images and store these images in OCI format. This allows, in a certain degree, reuse of the base image layer. When we use kk to push images, the kk re-tag images as xxx-arch[-variant] (e.g. xxx-amd64, xxx-arm-v7) and also use this package to copy images to a private registry, after that the kk use github.com/estesp/manifest-tool to push manifest-lists with the original tag of the images.
Which issue(s) this PR fixes:
Fixes #1139
Special notes for reviewers:
Does this PR introduced a user-facing change?
Breaking Change
The next release of KubeKey could not support using the old KubeKey artifact.
Because of the change in image store format, the KubeKey artifact must be re-export by kk.
Additional documentation, usage docs, etc.: