Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add KKLOCALIP env to specify local ip address for allinone cluster #2053

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

zliang90
Copy link
Contributor

@zliang90 zliang90 commented Nov 23, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

add an env `KKLOCALIP` to specific local ip address for allinone cluster

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 23, 2023
@zliang90 zliang90 force-pushed the feat_allinone_specify_localip branch from a14046d to 6f4232e Compare November 23, 2023 09:17
@zliang90 zliang90 force-pushed the feat_allinone_specify_localip branch from 6f4232e to bd7fea7 Compare November 23, 2023 09:18
@zliang90
Copy link
Contributor Author

/assign @pixiake

@pixiake
Copy link
Collaborator

pixiake commented Jan 15, 2024

@zliang90 Thanks for this contribution !
/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 6138f71f7023c5bd71570b729e28c278524b4db6

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, zliang90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@ks-ci-bot ks-ci-bot merged commit 600f0b2 into kubesphere:master Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants