avoid re-allocating ServerRunOptions #5108
Conversation
ks-ci-bot
added
kind/cleanup
|
Hi @ruijzhan. Thanks for your PR. I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ks-ci-bot
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
/ok-to-test |
|
@ruijzhan Thanks for your contribution! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruijzhan, wansir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 1172944451fcd42638207e357933a378823f719d
|
ks-ci-bot
added
the
approved
* Fix ks-core helm chart (#5101) * avoid re-allocating ServerRunOptions (#5108) * add alerting v2beta1 apis (#5115) * generate alerting resource client Signed-off-by: junot <junotxiang@kubesphere.io> * add alerting v2beta1 apis Signed-off-by: junot <junotxiang@kubesphere.io> * tweak some varibles and descs Signed-off-by: junot <junotxiang@kubesphere.io> * Fix the tiny typo in ks-openapi-spec (#5114) There is tiny typo in Create Namespace API. So fix it quickly. * Fix ingress P95 delay time promql statement (#5119) * intergrate opensearch v1 (#5135) opensearchv1 Signed-off-by: chengdehao <dehaocheng@kubesphere.io> Signed-off-by: chengdehao <dehaocheng@kubesphere.io> Co-authored-by: chengdehao <dehaocheng@kubesphere.io> * enhance globalrulegroups (#5134) Signed-off-by: junot <junotxiang@kubesphere.io> Signed-off-by: junot <junotxiang@kubesphere.io> * fix cluster ready condition always true (#5130) Signed-off-by: x893675 <x893675@icloud.com> Signed-off-by: x893675 <x893675@icloud.com> * fill field status of helmrepo in response (#5152) Signed-off-by: x893675 <x893675@icloud.com> Signed-off-by: x893675 <x893675@icloud.com> * Remove scheme duplicate registration code (#5147) Signed-off-by: junot <junotxiang@kubesphere.io> Signed-off-by: chengdehao <dehaocheng@kubesphere.io> Signed-off-by: x893675 <x893675@icloud.com> Co-authored-by: ruijzhan <qiudog825@gmail.com> Co-authored-by: junot <49136171+junotx@users.noreply.github.com> Co-authored-by: Hao Wang <sxmatch1986@gmail.com> Co-authored-by: Xinzhao Xu <z2d@jifangcheng.com> Co-authored-by: Elon Cheng <dehaocheng@yunify.com> Co-authored-by: chengdehao <dehaocheng@kubesphere.io> Co-authored-by: Hanamichi <x893675@icloud.com>
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR makes the ServerRunOptions init code clearer. Since the s.GenericServerRunOptions field already has its value, when "apiserverconfig.TryLoadFromDisk()" successes, only s.Config needs to be assigned with returned conf.
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: