Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tiny typo in ks-openapi-spec #5114

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

sxmatch
Copy link
Contributor

@sxmatch sxmatch commented Aug 3, 2022

There is tiny typo in Create Namespace API.
So fix it quickly.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@ks-ci-bot
Copy link
Collaborator

@sxmatch: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added do-not-merge/release-note-label-needed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Aug 3, 2022
@ks-ci-bot
Copy link
Collaborator

Hi @sxmatch. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xyz-li
Copy link
Contributor

xyz-li commented Aug 3, 2022

The sentence is generated from this line. You need correct the typo in it too.

Doc("List the namespaces of the specified workspace for the current user").

@sxmatch
Copy link
Contributor Author

sxmatch commented Aug 5, 2022

The sentence is generated from this line. You need correct the typo in it too.

Doc("List the namespaces of the specified workspace for the current user").

sure

There is tiny typo in Create Namespace API.
So fix it quickly.
@xyz-li
Copy link
Contributor

xyz-li commented Aug 8, 2022

/lgtm
/cc @wansir

@ks-ci-bot ks-ci-bot requested a review from wansir August 8, 2022 06:14
@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 558ec75cc914f6cce1500c55b56e1ccafc918dbf

@wansir
Copy link
Member

wansir commented Aug 10, 2022

/lgtm
/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sxmatch, wansir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2022
@ks-ci-bot ks-ci-bot merged commit 587dbe7 into kubesphere:master Aug 10, 2022
ks-ci-bot pushed a commit that referenced this pull request Aug 22, 2022
* Fix ks-core helm chart (#5101)

* avoid re-allocating ServerRunOptions (#5108)

* add alerting v2beta1 apis (#5115)

* generate alerting resource client

Signed-off-by: junot <junotxiang@kubesphere.io>

* add alerting v2beta1 apis

Signed-off-by: junot <junotxiang@kubesphere.io>

* tweak some varibles and descs

Signed-off-by: junot <junotxiang@kubesphere.io>

* Fix the tiny typo in ks-openapi-spec (#5114)

There is tiny typo in Create Namespace API.
So fix it quickly.

* Fix ingress P95 delay time promql statement (#5119)

* intergrate opensearch v1 (#5135)

opensearchv1

Signed-off-by: chengdehao <dehaocheng@kubesphere.io>

Signed-off-by: chengdehao <dehaocheng@kubesphere.io>
Co-authored-by: chengdehao <dehaocheng@kubesphere.io>

* enhance globalrulegroups (#5134)

Signed-off-by: junot <junotxiang@kubesphere.io>

Signed-off-by: junot <junotxiang@kubesphere.io>

* fix cluster ready condition always true (#5130)

Signed-off-by: x893675 <x893675@icloud.com>

Signed-off-by: x893675 <x893675@icloud.com>

* fill field status of helmrepo in response (#5152)

Signed-off-by: x893675 <x893675@icloud.com>

Signed-off-by: x893675 <x893675@icloud.com>

* Remove scheme duplicate registration code (#5147)

Signed-off-by: junot <junotxiang@kubesphere.io>
Signed-off-by: chengdehao <dehaocheng@kubesphere.io>
Signed-off-by: x893675 <x893675@icloud.com>
Co-authored-by: ruijzhan <qiudog825@gmail.com>
Co-authored-by: junot <49136171+junotx@users.noreply.github.com>
Co-authored-by: Hao Wang <sxmatch1986@gmail.com>
Co-authored-by: Xinzhao Xu <z2d@jifangcheng.com>
Co-authored-by: Elon Cheng <dehaocheng@yunify.com>
Co-authored-by: chengdehao <dehaocheng@kubesphere.io>
Co-authored-by: Hanamichi <x893675@icloud.com>
sologgfun pushed a commit to sologgfun/kubesphere that referenced this pull request Apr 24, 2023
There is tiny typo in Create Namespace API.
So fix it quickly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/release-note-label-needed lgtm Indicates that a PR is ready to be merged. needs-ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants