Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gateway upgrade validate error. #5232

Merged
merged 1 commit into from Sep 21, 2022

Conversation

hongzhouzi
Copy link
Member

@hongzhouzi hongzhouzi commented Sep 20, 2022

Signed-off-by: hongzhouzi hongzhouzi@kubesphere.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix gateway upgrade validate error.

Which issue(s) this PR fixes:

Fixes #5231

Does this PR introduced a user-facing change?

None

@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2022
@hongzhouzi
Copy link
Member Author

/cc @iawia002 @wansir

@iawia002
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: e6c38d43fd4a938b01547fddc06274b89c95ad65

@iawia002
Copy link
Member

Seems the imports of ./pkg/models/gateway/gateway.go file is not formatted, so job pull-kubesphere-verify failed.

Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io>
@ks-ci-bot ks-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2022
@hongzhouzi
Copy link
Member Author

/retest

@iawia002
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 7c49b74ff5721ca13a54b08bcc89d26ca7b5e526

@wansir
Copy link
Member

wansir commented Sep 21, 2022

/lgtm
/approve
/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@wansir: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongzhouzi, wansir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2022
@ks-ci-bot ks-ci-bot merged commit 73dcd0c into kubesphere:master Sep 21, 2022
@ks-ci-bot
Copy link
Collaborator

@wansir: new pull request created: #5236

In response to this:

/lgtm
/approve
/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sologgfun pushed a commit to sologgfun/kubesphere that referenced this pull request Apr 24, 2023
gateway upgrade validate error.

Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io>

Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io>
wanjunlei pushed a commit to wanjunlei/kubesphere that referenced this pull request Aug 11, 2023
gateway upgrade validate error.

Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io>

Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gateway upgrade with checksum error
4 participants