Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller/cluster: improve the process for updating the cluster certificate's expiration date #5665

Merged
merged 1 commit into from May 8, 2023

Conversation

iawia002
Copy link
Member

@iawia002 iawia002 commented May 5, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

fix #5395
fix #5664

Special notes for reviewers:

Does this PR introduced a user-facing change?

Improve the process for updating the cluster certificate's expiration date.

Additional documentation, usage docs, etc.:


/cc @wansir

@ks-ci-bot ks-ci-bot requested a review from wansir May 5, 2023 05:51
@ks-ci-bot ks-ci-bot added release-note kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 5, 2023
@hongzhouzi
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: d11b34671325946ef8b3cd1b9ff46b37456b1b38

@wansir
Copy link
Member

wansir commented May 8, 2023

/lgtm
/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iawia002, wansir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2023
@ks-ci-bot ks-ci-bot merged commit 16c2dbc into kubesphere:master May 8, 2023
3 checks passed
@iawia002 iawia002 deleted the fix-cluster-cert-sync branch May 8, 2023 09:48
ks-ci-bot pushed a commit that referenced this pull request May 19, 2023
…te (#5693)

* Remove the incorrect custom MarshalJSON method to avoid infinite recursion (#5624)

* Update utils.go (#5615)

* Update utils.go

All build alerting is not working

* Update utils.go

* revert viper version to v1.4.0 (#5626)

* revert viper version to v1.4.0

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update vendor

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

---------

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* Use the generic Set to replace deprecated methods (#5623)

* Bump github.com/docker/docker from 20.10.23+incompatible to 20.10.24+incompatible (#5627)

fix: Bump github.com/docker/docker from 20.10.23+incompatible to 20.10.24+incompatible

Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io>

* Move struct DynamicOptions to package pkg/server (#5625)

* move struct DynamicOptions to package pkg/server/dynamic_options.go

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update test types

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

---------

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* Merge multiple duplicate tools files (#5637)

* controller/cluster: retry when updating the KubeFedCluster conflicted (#5653)

* Fix:cannot get jobs by informer (#5656)

fix:cannot get jobs by informer

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* Uniform code format (#5650)

Signed-off-by: sologgfun <857949825@qq.com>

* controller/cluster: improve the process for updating the cluster certificate's expiration date (#5665)

* Bump github.com/emicklei/go-restful-openapi to v2.9.2-0.20230507070325-d6acc08e570c (#5669)

* Fix wrong params naming in openpitrix (#5666)

* refactor: remove usless options (#5671)

refactor: remove useless options

* Improve Unreasonable Comments (#5674)

Signed-off-by: sologgfun <857949825@qq.com>

* Add write operation for dynamic resource (#5601)

add write operation for dynamic resource

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* docs: modified section about style shields display issues in readme (#5677)

* docs: modified section about style shields display issues in readme

* Update README.md

* docs: modified section about style shields display issues in readme-zh (#5678)

* docs: modified section about style shields display issues in readme-zh

* docs: fix readme

* Bump github.com/docker/distribution from 2.8.1+incompatible to 2.8.2+incompatible (#5682)

fix: Bump github.com/docker/distribution from 2.8.1+incompatible to 2.8.2+incompatible

Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io>

* update imports

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* update ut-test

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

* generate iamv1beta1 crd manifests

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>

---------

Signed-off-by: wenhaozhou <wenhaozhou@yunify.com>
Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io>
Signed-off-by: sologgfun <857949825@qq.com>
Co-authored-by: Xinzhao Xu <z2d@jifangcheng.com>
Co-authored-by: chuan-you <117634014+chuan-you@users.noreply.github.com>
Co-authored-by: hongzhouzi <36416216+hongzhouzi@users.noreply.github.com>
Co-authored-by: AS! <857949825@qq.com>
Co-authored-by: hongming <hongming@kubesphere.io>
Co-authored-by: Xinwei Xiong <86140903+cubxxw@users.noreply.github.com>
wanjunlei pushed a commit to wanjunlei/kubesphere that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
4 participants