Improve Unreasonable Comments #5674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sologgfun <857949825@qq.com>
ks-ci-bot
added
kind/cleanup
|
Hi @sologgfun. Thanks for your PR. I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 4c077723faf827d85eb47104cfcf38838ca31ac7
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sologgfun, wansir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
wansir
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
ks-ci-bot
pushed a commit
that referenced
this pull request
May 19, 2023
…te (#5693) * Remove the incorrect custom MarshalJSON method to avoid infinite recursion (#5624) * Update utils.go (#5615) * Update utils.go All build alerting is not working * Update utils.go * revert viper version to v1.4.0 (#5626) * revert viper version to v1.4.0 Signed-off-by: wenhaozhou <wenhaozhou@yunify.com> * update vendor Signed-off-by: wenhaozhou <wenhaozhou@yunify.com> --------- Signed-off-by: wenhaozhou <wenhaozhou@yunify.com> * Use the generic Set to replace deprecated methods (#5623) * Bump github.com/docker/docker from 20.10.23+incompatible to 20.10.24+incompatible (#5627) fix: Bump github.com/docker/docker from 20.10.23+incompatible to 20.10.24+incompatible Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io> * Move struct DynamicOptions to package pkg/server (#5625) * move struct DynamicOptions to package pkg/server/dynamic_options.go Signed-off-by: wenhaozhou <wenhaozhou@yunify.com> * update test types Signed-off-by: wenhaozhou <wenhaozhou@yunify.com> --------- Signed-off-by: wenhaozhou <wenhaozhou@yunify.com> * Merge multiple duplicate tools files (#5637) * controller/cluster: retry when updating the KubeFedCluster conflicted (#5653) * Fix:cannot get jobs by informer (#5656) fix：cannot get jobs by informer Signed-off-by: wenhaozhou <wenhaozhou@yunify.com> * Uniform code format (#5650) Signed-off-by: sologgfun <857949825@qq.com> * controller/cluster: improve the process for updating the cluster certificate's expiration date (#5665) * Bump github.com/emicklei/go-restful-openapi to v2.9.2-0.20230507070325-d6acc08e570c (#5669) * Fix wrong params naming in openpitrix (#5666) * refactor: remove usless options (#5671) refactor: remove useless options * Improve Unreasonable Comments (#5674) Signed-off-by: sologgfun <857949825@qq.com> * Add write operation for dynamic resource (#5601) add write operation for dynamic resource Signed-off-by: wenhaozhou <wenhaozhou@yunify.com> * docs: modified section about style shields display issues in readme (#5677) * docs: modified section about style shields display issues in readme * Update README.md * docs: modified section about style shields display issues in readme-zh (#5678) * docs: modified section about style shields display issues in readme-zh * docs: fix readme * Bump github.com/docker/distribution from 2.8.1+incompatible to 2.8.2+incompatible (#5682) fix: Bump github.com/docker/distribution from 2.8.1+incompatible to 2.8.2+incompatible Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io> * update imports Signed-off-by: wenhaozhou <wenhaozhou@yunify.com> * update ut-test Signed-off-by: wenhaozhou <wenhaozhou@yunify.com> * generate iamv1beta1 crd manifests Signed-off-by: wenhaozhou <wenhaozhou@yunify.com> --------- Signed-off-by: wenhaozhou <wenhaozhou@yunify.com> Signed-off-by: hongzhouzi <hongzhouzi@kubesphere.io> Signed-off-by: sologgfun <857949825@qq.com> Co-authored-by: Xinzhao Xu <z2d@jifangcheng.com> Co-authored-by: chuan-you <117634014+chuan-you@users.noreply.github.com> Co-authored-by: hongzhouzi <36416216+hongzhouzi@users.noreply.github.com> Co-authored-by: AS! <857949825@qq.com> Co-authored-by: hongming <hongming@kubesphere.io> Co-authored-by: Xinwei Xiong <86140903+cubxxw@users.noreply.github.com>
wanjunlei
pushed a commit
to wanjunlei/kubesphere
that referenced
this pull request
Aug 11, 2023
Signed-off-by: sologgfun <857949825@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
During the process of reading the code, I found some unreasonable comments. After some research, I discovered that these are in the comments of the sample-controller case in the k8s source code.
Such comments seem rather unprofessional, so I'm making corrections.
Which issue(s) this PR fixes:
Fixes none