Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue about setting customized cluster name when using kubespray #104

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

jianzj
Copy link

@jianzj jianzj commented Aug 31, 2017

openstack

When using kubespray openstack to initialize environment and deploy
kubernetes cluster, if you want to setup a cluster name with
--cluster-name, you will always receive errors like

TASK [Create nodes network ports]
**********************************************
failed: [localhost] (item=k8s-phenomenal-ootp8f) => {"failed": true,
"item": "k8s-phenomenal-ootp8f", "msg": "Security group:
k8s-phenomenal-69k17f, was not found"}
failed: [localhost] (item=k8s-phenomenal-ystmto) => {"failed": true,
"item": "k8s-phenomenal-ystmto", "msg": "Security group:
k8s-phenomenal-69k17f, was not found"}
failed: [localhost] (item=k8s-phenomenal-k2f8sf) => {"failed": true,
"item": "k8s-phenomenal-k2f8sf", "msg": "Security group:
k8s-phenomenal-69k17f, was not found"}

That is because security group name is redefined and security group is
not created with these names.

These is one issue existing,
#64

I did some code changes, which cluster_name will be changed at the first
place when customer set a new one.

Please help to review and let me know if anything that I could update or
improve.

openstack

When using `kubespray openstack` to initialize environment and deploy
kubernetes cluster, if you want to setup a cluster name with
`--cluster-name`, you will always receive errors like 

```
TASK [Create nodes network ports]
**********************************************
failed: [localhost] (item=k8s-phenomenal-ootp8f) => {"failed": true,
"item": "k8s-phenomenal-ootp8f", "msg": "Security group:
k8s-phenomenal-69k17f, was not found"}
failed: [localhost] (item=k8s-phenomenal-ystmto) => {"failed": true,
"item": "k8s-phenomenal-ystmto", "msg": "Security group:
k8s-phenomenal-69k17f, was not found"}
failed: [localhost] (item=k8s-phenomenal-k2f8sf) => {"failed": true,
"item": "k8s-phenomenal-k2f8sf", "msg": "Security group:
k8s-phenomenal-69k17f, was not found"}
```

That is because security group name is redefined and security group is
not created with these names. 

These is one issue existing,
kubespray#64

I did some code changes, which cluster_name will be changed at the first
place when customer set a new one.

Please help to review and let me know if anything that I could update or
improve.
@Smana
Copy link
Contributor

Smana commented Aug 31, 2017

Thank you and sorry i didn't do many tests on openstack

@Smana Smana merged commit 0c90f28 into kubespray:master Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants