This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
Bug 1942137: Add show/hide password feature via new ValidatedPasswordField component #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
valid bug 1942137 |
|
🚀 Deployed Preview: http://konveyor-forklift-ui-pr-524-preview.surge.sh ✨ Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh |
Codecov Report
@@ Coverage Diff @@
## main #524 +/- ##
==========================================
+ Coverage 59.70% 59.91% +0.20%
==========================================
Files 133 134 +1
Lines 4301 4323 +22
Branches 1069 1076 +7
==========================================
+ Hits 2568 2590 +22
Misses 1709 1709
Partials 24 24
Continue to review full report at Codecov.
|
This was referenced Apr 7, 2021
ghost
approved these changes
Apr 7, 2021
ghost
merged commit 
apinnick
reviewed
Apr 8, 2021
| label="Password" | ||
| isRequired | ||
| fieldId="vmware-password" | ||
| /> | ||
| <ValidatedTextInput | ||
| field={vmwareForm.fields.fingerprint} | ||
| label="Certificate SHA1 Fingerprint" | ||
| label="SHA-1 Fingerprint" |
There was a problem hiding this comment.
"Fingerprint" should be "fingerprint", per PF4 guidelines.
There was a problem hiding this comment.
Agh dammit, thanks @apinnick. Will fix in another PR.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #468 (https://bugzilla.redhat.com/show_bug.cgi?id=1942137)
Also resolves #452 in the interest of time, because separate PRs for these two fixes would conflict.
Adds a new common component
ValidatedPasswordFieldwhich adds a show/hide icon button on the right side of the field. Replaces the plain password input with this component in 3 places: VMware provider password, OpenShift provider SA token, and ESXi host admin password.The first commit puts the toggle icon next to the field label like it's done in MTC today, but then @vconzola pointed out that the PatternFly login page example has the icon in an InputGroup next to the input field (see patternfly/patternfly-react#5481), so the second commit switches to that design.
I had to duplicate some of the code from the lib-ui ValidatedTextInput component since it doesn't support InputGroups. We can add that feature to lib-ui and simplify this code in the future. Opened migtools/lib-ui#55 to track this.