Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: translate of build addon registry #871

Merged
merged 4 commits into from
Aug 2, 2022
Merged

doc: translate of build addon registry #871

merged 4 commits into from
Aug 2, 2022

Conversation

cezhang
Copy link
Member

@cezhang cezhang commented Jul 22, 2022

#814
Signed-off-by: cezhang c1zhang.dev@gmail.com

@charlie0129
Copy link
Member

charlie0129 commented Jul 22, 2022 •
edited
Loading

Sorry but the file inside zh is not up-to-date #814 (comment) . Would you please check https://kubevela.net/docs/next/platform-engineers/addon/addon-registry for the latest version and base your translations on that?

@cezhang
Copy link
Member Author

cezhang commented Jul 22, 2022

Sorry but the file inside zh is not up-to-date #814 (comment) . Would you please check https://kubevela.net/docs/next/platform-engineers/addon/addon-registry for the latest version and base your translations on that?

OMG, my bad.

charlie0129
charlie0129 reviewed Jul 24, 2022
View reviewed changes
i18n/zh/docusaurus-plugin-content-docs/current/platform-engineers/addon/addon-registry.md

```yaml
vela addon registry add my-repo --type gitlab --gitRepoName=<repoName> --endpoint=<URL> --path=<ptah> --gitToken=<git token>
```

## Helm chart repository as registry
## 构建和推送到定制的 Helm Chart 仓库
Copy link
Member

@charlie0129 charlie0129 Jul 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 构建和推送到定制的 Helm Chart 仓库
## 自建并推送到 Helm Chart 仓库

charlie0129
charlie0129 suggested changes Jul 24, 2022
View reviewed changes
Copy link
Member

@charlie0129 charlie0129 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Thanks for your contribution.

But please note: 如果使用机翻请一定通读一遍保持语句通顺，在中文中使用英文语序是难以阅读的；同时请不要遗漏原文内容；英语跟中文的表达方式有较大差异，不能生搬硬套，可用适当意译来更好地表达原文意思。

@charlie0129 charlie0129 mentioned this pull request Jul 27, 2022
Closed
cezhang and others added 4 commits August 2, 2022 11:18
@cezhang
doc: translate of build addon registry
ce3a07c 
Signed-off-by: cezhang <c1zhang.dev@gmail.com>
@cezhang
update orginal docs and translate
6e75894 
Signed-off-by: cezhang <c1zhang.dev@gmail.com>
@cezhang @charlie0129
Apply suggestions from code review
68ffe87 
Co-authored-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: cezhang <c1zhang.dev@gmail.com>
@cezhang
update docs in v1.4
2bdb16d 
Signed-off-by: cezhang <c1zhang.dev@gmail.com>
wonderflow
wonderflow approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@wonderflow wonderflow merged commit 047426c into kubevela:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlie0129 charlie0129 charlie0129 requested changes

@wonderflow wonderflow wonderflow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cezhang @charlie0129 @wonderflow