Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep docker binary command due to the issue #416 #1478

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

chengshiwen
Copy link
Contributor

Brief changes:

This closes #416, and closes #1233 (pr)

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #1478 (ab99b4b) into master (580157d) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1478      +/-   ##
==========================================
- Coverage   53.08%   52.94%   -0.14%     
==========================================
  Files          85       85              
  Lines        8259     8259              
==========================================
- Hits         4384     4373      -11     
- Misses       3344     3353       +9     
- Partials      531      533       +2     
Flag Coverage Δ
unittests 52.94% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/builtin/build/build.go 14.47% <ø> (ø)
...aits/traitdefinition/traitdefinition_controller.go 62.79% <0.00%> (-18.61%) ⬇️
...ha2/core/components/componentdefinition/handler.go 72.72% <0.00%> (-9.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580157d...ab99b4b. Read the comment docs.

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks good job

@wonderflow wonderflow merged commit e8ed4d7 into kubevela:master Apr 14, 2021
chivalryq pushed a commit to chivalryq/kubevela that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use buildkit to build docker images
2 participants