Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: adapt vela port-forward with the velaql #4439

Merged
merged 1 commit into from Jul 25, 2022

Conversation

wonderflow
Copy link
Collaborator

@wonderflow wonderflow commented Jul 25, 2022

Signed-off-by: Jianbo Sun jianbo.sjb@alibaba-inc.com

Description of your changes

adapt vela port-forward with the velaql

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@wonderflow wonderflow added area/cli backport release-1.5 add this label will automatically backport this PR to release-1.5 branch labels Jul 25, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #4439 (6a9064b) into master (6a9064b) will not change coverage.
The diff coverage is n/a.

❗ Current head 6a9064b differs from pull request most recent head 50f902e. Consider uploading reports for the commit 50f902e to get more accurate results

@@           Coverage Diff           @@
##           master    #4439   +/-   ##
=======================================
  Coverage   61.58%   61.58%           
=======================================
  Files         348      348           
  Lines       34425    34425           
=======================================
  Hits        21201    21201           
  Misses      10467    10467           
  Partials     2757     2757           
Flag Coverage Δ
apiserver-e2etests 27.63% <0.00%> (ø)
apiserver-unittests 40.25% <0.00%> (ø)
core-unittests 56.52% <0.00%> (ø)
e2e-multicluster-test 19.75% <0.00%> (ø)
e2e-rollout-tests 22.93% <0.00%> (ø)
e2etests 29.39% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a9064b...50f902e. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jul 25, 2022

This pull request fixes 1 alert when merging e6ba80e into e2031c1 - view on LGTM.com

fixed alerts:

  • 1 for Off-by-one comparison against length

@lgtm-com
Copy link

lgtm-com bot commented Jul 25, 2022

This pull request introduces 1 alert and fixes 1 when merging de2a99d into 572fba3 - view on LGTM.com

new alerts:

  • 1 for Incorrect conversion between integer types

fixed alerts:

  • 1 for Off-by-one comparison against length

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
@lgtm-com
Copy link

lgtm-com bot commented Jul 25, 2022

This pull request introduces 1 alert and fixes 1 when merging 50f902e into 6a9064b - view on LGTM.com

new alerts:

  • 1 for Incorrect conversion between integer types

fixed alerts:

  • 1 for Off-by-one comparison against length

@github-actions
Copy link

Successfully created backport PR #4453 for release-1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli backport release-1.5 add this label will automatically backport this PR to release-1.5 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants