Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: workflow will rerun when application workflow changes #4808

Merged
merged 1 commit into from Sep 29, 2022

Conversation

Somefive
Copy link
Collaborator

Signed-off-by: Somefive yd219913@alibaba-inc.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 60.76% // Head: 60.84% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (62be08b) compared to base (b5f0363).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4808      +/-   ##
==========================================
+ Coverage   60.76%   60.84%   +0.08%     
==========================================
  Files         298      298              
  Lines       30867    30865       -2     
==========================================
+ Hits        18756    18781      +25     
+ Misses       9641     9615      -26     
+ Partials     2470     2469       -1     
Flag Coverage Δ
apiserver-e2etests 30.15% <ø> (+0.03%) ⬆️
apiserver-unittests 40.43% <ø> (-0.05%) ⬇️
core-unittests 54.79% <ø> (+0.16%) ⬆️
e2e-multicluster-test 19.30% <ø> (-0.12%) ⬇️
e2e-rollout-tests 21.47% <ø> (+0.17%) ⬆️
e2etests 27.42% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ller/core.oam.dev/v1alpha2/application/revision.go 72.57% <ø> (-0.11%) ⬇️
pkg/resourcekeeper/gc.go 78.09% <0.00%> (-2.48%) ⬇️
pkg/addon/push.go 75.20% <0.00%> (-1.60%) ⬇️
pkg/controller/utils/capability.go 83.40% <0.00%> (-1.37%) ⬇️
pkg/apiserver/domain/service/authentication.go 50.66% <0.00%> (-1.00%) ⬇️
pkg/multicluster/virtual_cluster.go 91.86% <0.00%> (-0.82%) ⬇️
pkg/apiserver/domain/service/workflow.go 52.40% <0.00%> (-0.66%) ⬇️
pkg/apiserver/event/sync/cr2ux.go 53.22% <0.00%> (ø)
...server/infrastructure/datastore/kubeapi/kubeapi.go 63.87% <0.00%> (+0.38%) ⬆️
...dev/v1alpha2/application/application_controller.go 87.42% <0.00%> (+0.59%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive added the backport release-1.5 add this label will automatically backport this PR to release-1.5 branch label Sep 29, 2022
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add test case to cover it

Signed-off-by: Somefive <yd219913@alibaba-inc.com>
@wonderflow wonderflow merged commit feca6cc into kubevela:master Sep 29, 2022
@github-actions
Copy link

Backport failed for release-1.5, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.5
git worktree add -d .worktree/backport-4808-to-release-1.5 origin/release-1.5
cd .worktree/backport-4808-to-release-1.5
git checkout -b backport-4808-to-release-1.5
ancref=$(git merge-base b5f0363a3d819e8b248045d59a371c1b2a267404 62be08ba2b81da431b4e7658c92b58b76605c7b7)
git cherry-pick -x $ancref..62be08ba2b81da431b4e7658c92b58b76605c7b7

@Somefive Somefive deleted the feat/workflow-change-rerun branch September 30, 2022 02:18
FogDong pushed a commit to FogDong/kubevela that referenced this pull request Oct 14, 2022
…#4808)

Signed-off-by: Somefive <yd219913@alibaba-inc.com>

Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.5 add this label will automatically backport this PR to release-1.5 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants