Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-1.5] Feat: workflow will rerun when application workflow changes #4813

Merged

Conversation

Somefive
Copy link
Collaborator

@Somefive Somefive commented Sep 30, 2022

Signed-off-by: Somefive yd219913@alibaba-inc.com

Description of your changes

Cherry-pick #4808 into release-1.5.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 59.33% // Head: 61.42% // Increases project coverage by +2.08% 🎉

Coverage data is based on head (fc92804) compared to base (d599e63).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #4813      +/-   ##
===============================================
+ Coverage        59.33%   61.42%   +2.08%     
===============================================
  Files              344      349       +5     
  Lines            34666    34804     +138     
===============================================
+ Hits             20570    21379     +809     
+ Misses           11391    10643     -748     
- Partials          2705     2782      +77     
Flag Coverage Δ
apiserver-e2etests 28.22% <ø> (-0.07%) ⬇️
apiserver-unittests 40.37% <ø> (+0.02%) ⬆️
core-unittests 56.58% <ø> (+0.03%) ⬆️
e2e-multicluster-test 21.16% <ø> (?)
e2e-rollout-tests 23.26% <ø> (-0.17%) ⬇️
e2etests 27.44% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ller/core.oam.dev/v1alpha2/application/revision.go 73.21% <ø> (+2.09%) ⬆️
apis/core.oam.dev/v1beta1/policy_definition.go 0.00% <0.00%> (-50.00%) ⬇️
.../manualscalertrait/manualscalertrait_controller.go 11.11% <0.00%> (-50.00%) ⬇️
apis/core.oam.dev/v1alpha2/methods.go 0.00% <0.00%> (-25.00%) ⬇️
pkg/apiserver/event/sync/cr2ux.go 45.16% <0.00%> (-12.91%) ⬇️
...kg/apiserver/infrastructure/datastore/datastore.go 66.66% <0.00%> (-11.12%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 62.96% <0.00%> (-4.63%) ⬇️
pkg/apiserver/event/sync/worker.go 75.92% <0.00%> (-3.71%) ⬇️
...server/infrastructure/datastore/kubeapi/kubeapi.go 62.73% <0.00%> (-1.91%) ⬇️
pkg/addon/addon.go 62.64% <0.00%> (-1.33%) ⬇️
... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive closed this Sep 30, 2022
@Somefive Somefive reopened this Sep 30, 2022
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
@Somefive Somefive force-pushed the feat/1.5/rerun-workflow-change branch from ecac8d9 to fc92804 Compare September 30, 2022 05:59
@wonderflow wonderflow merged commit 5a98541 into kubevela:release-1.5 Sep 30, 2022
@Somefive Somefive deleted the feat/1.5/rerun-workflow-change branch June 20, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants