Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: vela cluster join supports label setting arg #5346

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Feat: vela cluster join supports label setting arg #5346

merged 1 commit into from
Jan 16, 2023

Conversation

previousdeveloper
Copy link
Contributor

@previousdeveloper previousdeveloper commented Jan 13, 2023 •
edited by wonderflow

Issue: #5171
Signed-off-by: Gokhan Karadas gokhan.karadas@trendyol.com

Description of your changes

It allows adding a cluster label when new target cluster is added.
#5171

Fixes #5171

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@previousdeveloper previousdeveloper changed the title [Feature] vela cluster join supports lable setting arg Feat vela cluster join supports lable setting arg Jan 13, 2023
@previousdeveloper previousdeveloper changed the title Feat vela cluster join supports lable setting arg Feat: vela cluster join supports lable setting arg Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023 •
edited

Codecov Report

Base: 36.20% // Head: 61.33% // Increases project coverage by +25.12% 🎉

Coverage data is based on head (4188e02) compared to base (5158fcf).
Patch has no changes to coverable lines.

❗ Current head 4188e02 differs from pull request most recent head 729560b. Consider uploading reports for the commit 729560b to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #5346       +/-   ##
===========================================
+ Coverage   36.20%   61.33%   +25.12%     
===========================================
  Files          87      308      +221     
  Lines       18415    46788    +28373     
===========================================
+ Hits         6668    28699    +22031     
- Misses      10848    15135     +4287     
- Partials      899     2954     +2055
Flag Coverage Δ
apiserver-e2etests 32.32% <ø> (?)
apiserver-unittests 36.23% <ø> (+0.02%) ⬆️
core-unittests 55.36% <ø> (?)
e2e-multicluster-test 19.03% <ø> (?)
e2e-rollout-tests 21.02% <ø> (?)
e2etests 26.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oam.dev/v1alpha2/application/validating_handler.go 80.39% <0.00%> (ø)
pkg/utils/env/env.go 9.59% <0.00%> (ø)
...ller/core.oam.dev/v1alpha2/application/revision.go 71.74% <0.00%> (ø)
pkg/auth/identity.go 76.05% <0.00%> (ø)
pkg/addon/addon.go 63.33% <0.00%> (ø)
pkg/appfile/validate.go 75.00% <0.00%> (ø)
pkg/multicluster/errors.go 100.00% <0.00%> (ø)
pkg/resourcekeeper/containsresources.go 80.00% <0.00%> (ø)
pkg/auth/privileges.go 69.38% <0.00%> (ø)
pkg/addon/reader_github.go 14.00% <0.00%> (ø)
... and 284 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Somefive
Somefive approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@Somefive Somefive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@Somefive Somefive changed the title Feat: vela cluster join supports lable setting arg Feat: vela cluster join supports label setting arg Jan 16, 2023
@wonderflow
Copy link
Collaborator

please sign the DCO

Feat: reuse same logic for cluster labels
729560b 
Issue: kubevela#5171

Signed-off-by: Gokhan Karadas <gokhan.karadas@trendyol.com>
@previousdeveloper
Copy link
Contributor Author

please sign the DCO

done

@wonderflow wonderflow merged commit 4ec9214 into kubevela:master Jan 16, 2023
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
@previousdeveloper @zhaohuiweixiao
Feat: reuse same logic for cluster labels (kubevela#5346)
f549916 
Issue: kubevela#5171

Signed-off-by: Gokhan Karadas <gokhan.karadas@trendyol.com>

Signed-off-by: Gokhan Karadas <gokhan.karadas@trendyol.com>
Co-authored-by: Gokhan Karadas <gokhan.karadas@trendyol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Somefive Somefive Somefive approved these changes

@zzxwill zzxwill Awaiting requested review from zzxwill

@StevenLeiZhang StevenLeiZhang Awaiting requested review from StevenLeiZhang StevenLeiZhang is a code owner

@charlie0129 charlie0129 Awaiting requested review from charlie0129 charlie0129 is a code owner

@chivalryq chivalryq Awaiting requested review from chivalryq chivalryq is a code owner

@wonderflow wonderflow Awaiting requested review from wonderflow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] vela cluster join supports lable setting arg
3 participants
@previousdeveloper @wonderflow @Somefive