Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix bugs of specified addon registry #5404

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

wangyikewxgm
Copy link
Collaborator

fix bugs of specified addon registry

Signed-off-by: 楚岳 wangyike.wyk@alibaba-inc.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
@wangyikewxgm wangyikewxgm added backport release-1.6 add this label will automatically backport this PR to release-1.6 branch backport release-1.7 add this label will automatically backport this PR to release-1.7 branch labels Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 61.41% // Head: 61.32% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (3a9df79) compared to base (17bff50).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5404      +/-   ##
==========================================
- Coverage   61.41%   61.32%   -0.10%     
==========================================
  Files         315      315              
  Lines       47264    47264              
==========================================
- Hits        29027    28983      -44     
- Misses      15234    15267      +33     
- Partials     3003     3014      +11     
Flag Coverage Δ
apiserver-e2etests 35.52% <ø> (+0.01%) ⬆️
apiserver-unittests 36.23% <ø> (-0.03%) ⬇️
core-unittests 55.05% <ø> (-0.05%) ⬇️
e2e-multicluster-test 19.25% <ø> (-0.04%) ⬇️
e2e-rollout-tests 20.60% <ø> (-0.02%) ⬇️
e2etests 25.98% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/policydefinition/policydefinition_controller.go 73.17% <0.00%> (-7.32%) ⬇️
pkg/apiserver/interfaces/api/oam_application.go 59.18% <0.00%> (-5.11%) ⬇️
pkg/apiserver/event/sync/cr2ux.go 51.68% <0.00%> (-4.50%) ⬇️
...dev/v1alpha2/application/application_controller.go 82.79% <0.00%> (-3.96%) ⬇️
pkg/apiserver/utils/bcode/bcode.go 51.11% <0.00%> (-2.23%) ⬇️
...server/infrastructure/datastore/kubeapi/kubeapi.go 62.97% <0.00%> (-1.90%) ⬇️
pkg/apiserver/event/sync/convert/convert.go 80.35% <0.00%> (-1.79%) ⬇️
pkg/apiserver/domain/service/authentication.go 48.57% <0.00%> (-1.30%) ⬇️
pkg/addon/push.go 75.14% <0.00%> (-1.13%) ⬇️
pkg/multicluster/virtual_cluster.go 76.19% <0.00%> (-1.10%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wangyikewxgm wangyikewxgm marked this pull request as draft February 1, 2023 08:08
@wangyikewxgm wangyikewxgm marked this pull request as ready for review February 1, 2023 08:34
@Somefive Somefive merged commit 1b993ff into kubevela:master Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Backport failed for release-1.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.6
git worktree add -d .worktree/backport-5404-to-release-1.6 origin/release-1.6
cd .worktree/backport-5404-to-release-1.6
git checkout -b backport-5404-to-release-1.6
ancref=$(git merge-base 17bff50005c595a001f52a9b4486d6e6890c30d9 3a9df79b3a6eb2be09e24ee2b37b52a09ffa3e29)
git cherry-pick -x $ancref..3a9df79b3a6eb2be09e24ee2b37b52a09ffa3e29

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Successfully created backport PR #5407 for release-1.7.

zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.6 add this label will automatically backport this PR to release-1.6 branch backport release-1.7 add this label will automatically backport this PR to release-1.7 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants