Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix krew release with new binary format for .exe #5459

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

wonderflow
Copy link
Collaborator

@wonderflow wonderflow commented Feb 8, 2023

Signed-off-by: Jianbo Sun jianbo.sjb@alibaba-inc.com

Description of your changes

Fixes kubernetes-sigs/krew-index#2928

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
@wonderflow wonderflow added the backport release-1.7 add this label will automatically backport this PR to release-1.7 branch label Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 59.35% // Head: 61.31% // Increases project coverage by +1.95% 🎉

Coverage data is based on head (a4ea6cc) compared to base (6dc9dda).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5459      +/-   ##
==========================================
+ Coverage   59.35%   61.31%   +1.95%     
==========================================
  Files         305      310       +5     
  Lines       46946    47160     +214     
==========================================
+ Hits        27867    28914    +1047     
+ Misses      16146    15256     -890     
- Partials     2933     2990      +57     
Flag Coverage Δ
apiserver-e2etests 35.63% <ø> (+0.03%) ⬆️
apiserver-unittests 36.25% <ø> (ø)
core-unittests 55.37% <ø> (+0.07%) ⬆️
e2e-multicluster-test 18.96% <ø> (?)
e2e-rollout-tests 20.73% <ø> (+0.01%) ⬆️
e2etests 26.15% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/addon/cache.go 47.78% <0.00%> (-7.53%) ⬇️
pkg/apiserver/interfaces/api/oam_application.go 59.18% <0.00%> (-5.11%) ⬇️
...es/policydefinition/policydefinition_controller.go 80.48% <0.00%> (-3.66%) ⬇️
pkg/apiserver/utils/bcode/bcode.go 51.11% <0.00%> (-2.23%) ⬇️
.../core/scopes/healthscope/healthscope_controller.go 71.71% <0.00%> (-0.44%) ⬇️
pkg/addon/registry.go 51.26% <0.00%> (ø)
pkg/apiserver/domain/service/application.go 58.43% <0.00%> (ø)
...troller/core.oam.dev/v1alpha2/application/apply.go 86.07% <0.00%> (ø)
pkg/cmd/builder.go 79.72% <0.00%> (ø)
pkg/cmd/completion.go 0.00% <0.00%> (ø)
... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Successfully created backport PR #5462 for release-1.7.

zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.7 add this label will automatically backport this PR to release-1.7 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants